Fix fetchData
The fetchData function suffer from a race condition. If the function is called before the promise finishes, it will result in another pair of HTTP request. This does not only make the function useless but Actually, it makes it harmful as the data might be redownloaded twice. Now fetchData is not a function but rather the promise by itself. Previous callers are expected to await the variable instead, this should be not concern as awaiting a promise multiple time in JavaScript is completely safe.
This commit is contained in:
parent
1313bd9779
commit
7e0f2e4449
7 changed files with 16 additions and 26 deletions
|
@ -1,5 +1,5 @@
|
|||
async function drawGraph(url, baseUrl, pathColors, depth, enableDrag, enableLegend, enableZoom) {
|
||||
const { index, links, content } = await fetchData()
|
||||
const { index, links, content } = await fetchData
|
||||
const curPage = url.replace(baseUrl, "")
|
||||
|
||||
const parseIdsFromLinks = (links) => [...(new Set(links.flatMap(link => ([link.source, link.target]))))]
|
||||
|
|
|
@ -8,7 +8,7 @@ function htmlToElement(html) {
|
|||
function initPopover(base) {
|
||||
const baseUrl = base.replace(window.location.origin, "") // is this useless?
|
||||
document.addEventListener("DOMContentLoaded", () => {
|
||||
fetchData().then(({content}) => {
|
||||
fetchData.then(({content}) => {
|
||||
const links = [...document.getElementsByClassName("internal-link")]
|
||||
links.forEach(li => {
|
||||
const linkDest = content[li.dataset.src.replace(baseUrl, "")]
|
||||
|
|
|
@ -81,7 +81,7 @@ const removeMarkdown = (
|
|||
}
|
||||
})
|
||||
|
||||
const { content } = await fetchData()
|
||||
const { content } = await fetchData
|
||||
for (const [key, value] of Object.entries(content)) {
|
||||
contentIndex.add({
|
||||
id: key,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue